Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moar ng_package #22628

Closed
wants to merge 3 commits into from
Closed

Moar ng_package #22628

wants to merge 3 commits into from

Conversation

alexeagle
Copy link
Contributor

Now we can build @angular/bazel and @angular/router

@alexeagle alexeagle requested a review from jasonaden March 7, 2018 18:14
@alexeagle alexeagle mentioned this pull request Mar 7, 2018
Closed
3 tasks
@alexeagle alexeagle added target: major This PR is targeted for the next major release area: build & ci Related the build and CI infrastructure of the project labels Mar 7, 2018
@alan-agius4
Copy link
Contributor

Thanks for this Alex!

@mary-poppins
Copy link

You can preview daa49e9 at https://pr22628-daa49e9.ngbuilds.io/.

@alexeagle
test: include router in public_api_guard tests
233db2b 
Remove duplicate public api testing from the gulp task.
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2018
@mary-poppins
Copy link

You can preview 233db2b at https://pr22628-233db2b.ngbuilds.io/.

@alexeagle alexeagle closed this in fcb8c49 Mar 7, 2018
alexeagle added a commit that referenced this pull request Mar 7, 2018
@alexeagle
build: add a ng_package rule for @angular/router (#22628)
ce649f7 
PR Close #22628
alexeagle added a commit that referenced this pull request Mar 7, 2018
@alexeagle
test: include router in public_api_guard tests (#22628)
ad8fb84 
Remove duplicate public api testing from the gulp task.

PR Close #22628
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@alexeagle @leo6104
build: add an npm_package rule for @angular/bazel (angular#22628)
9e4c156 
PR Close angular#22628
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@alexeagle @leo6104
build: add a ng_package rule for @angular/router (angular#22628)
624a4fc 
PR Close angular#22628
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@alexeagle @leo6104
test: include router in public_api_guard tests (angular#22628)
dc9624d 
Remove duplicate public api testing from the gulp task.

PR Close angular#22628
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@alexeagle
build: add a ng_package rule for @angular/router (angular#22628)
2d5a7db 
PR Close angular#22628
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexeagle @alan-agius4 @mary-poppins @IgorMinar @jasonaden @googlebot