Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build.sh for package group and add a test #22638

Closed
wants to merge 1 commit into from
Closed

build: fix build.sh for package group and add a test #22638

wants to merge 1 commit into from

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Mar 8, 2018

pretty much ☝️

@hansl hansl added the target: major This PR is targeted for the next major release label Mar 8, 2018
@hansl
Copy link
Contributor Author

hansl commented Mar 8, 2018 •
edited

Bit of context, we require @angular/core (etc etc) in package.json, but before this change only /core was added as apparently @ is a reserved symbol in perl's regex. This adds a test for checking it too so if someone changes / break the logic it still work.

@hansl hansl force-pushed the angular-package-group-fix branch from a3a3e28 to b103d05 Compare March 8, 2018 00:59
@hansl hansl force-pushed the angular-package-group-fix branch from b103d05 to 21f2a6b Compare March 8, 2018 02:15
@alexeagle alexeagle added the area: build & ci Related the build and CI infrastructure of the project label Mar 8, 2018
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2018
@mhevery mhevery closed this in f256c02 Mar 15, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@hansl @leo6104
build: fix build.sh for package group and add a test (angular#22638)
f2cd884 
PR Close angular#22638
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansl @IgorMinar @alexeagle @googlebot