Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): render doc-gen issues in overview dump #22675

Closed
wants to merge 1 commit into from
Closed

build(aio): render doc-gen issues in overview dump #22675

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Related to #22138

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: major This PR is targeted for the next major release labels Mar 9, 2018
@mary-poppins
Copy link

You can preview 6bd333b at https://pr22675-6bd333b.ngbuilds.io/.

@petebacondarwin
Copy link
Member Author

You can view the report here: https://pr22675-6bd333b.ngbuilds.io/generated/docs/overview-dump.html

screen shot 2018-03-09 at 10 33 19

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Mar 9, 2018
@gkalpak
Copy link
Member

gkalpak commented Mar 12, 2018

Why does it think that getAngularJSGlobal() is undocumented?

@petebacondarwin
Copy link
Member Author

Why does it think that getAngularJSGlobal() is undocumented?

I have no idea! This seems like a bug! I am surprised that you approved it given that issue.

@gkalpak
Copy link
Member

gkalpak commented Mar 12, 2018

I am surprised that you approved it given that issue.

The error didn't seem related to this PR 😉

@petebacondarwin
Copy link
Member Author

True. I'll fix in a follow up PR

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 13, 2018
@petebacondarwin petebacondarwin mentioned this pull request Mar 13, 2018
Closed
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Mar 13, 2018
@kara
Copy link
Contributor

kara commented Mar 14, 2018

@petebacondarwin Would you mind rebasing this?

@petebacondarwin
Copy link
Member Author

@kara - of course. Done. Thank you.

@mary-poppins
Copy link

You can preview 5c72298 at https://pr22675-5c72298.ngbuilds.io/.

@kara kara closed this in 6f0dad1 Mar 14, 2018
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Mar 14, 2018
@petebacondarwin petebacondarwin deleted the aio-api-overview-dump branch March 14, 2018 19:30
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@petebacondarwin @leo6104
build(aio): render doc-gen issues in overview dump (angular#22675)
e6bc91d 
Related to angular#22138

PR Close angular#22675
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petebacondarwin @mary-poppins @gkalpak @kara @googlebot