build(compiler-cli): fix tsconfig.json

[benbraou]

Fixes #22721

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In compiler-cli/tsconfig.json, there is a circularity issue (it is extending itself)

{
   "extends": "./tsconfig.json",
   "compilerOptions": {
       "target": "es2015",
       "lib": [
           "es2015"
       ]
   }
}

Issue Number: N/A
#22721

What is the new behavior?

update compiler-cli/tsconfig.json introduced by c602563

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[benbraou]

I removed the tsconfig.json which made all dependencies in compiler-cli spec files resolved correctly.
Hopefully, this is the accepted way to go

[IgorMinar]

It's odd that my VS Code doesn't complain about this. It is obviously wrong.

However if you delete the file, the editors will not understand that it's ok to use es2015 apis in the compiler-cli code. The proper fix would be to change the extends to "../tsconfig.json". Can you please update your PR to that?

[benbraou]

Thanks @IgorMinar for the feedback

1. My VS Code started to complain after I deleted both node_modules and dist folders and then I did yarn install + run build and test scripts. Maybe this is how you could reproduce
2. I updated my PR as you suggested to have compiler-cli/tsconfig.json have the "extends": "../tsconfig.json"
3. When I did that, all dependencies in the spec files were correctly resolved. However, jasmine types were missing (I kept getting the error Cannot find name 'describe' )

4. So, I declared the type `jasmine` in `compiler-cli/tsconfig.json` and that solved the issue for me.

I have updated my PR accordingly. Please let me know if this is not the way to go

[benbraou]

rebased on top of master and force pushed in order to have a new travis build (previous was failing due to timeout in aio)

[ngbot]

I see that you just added the PR action: merge label, but the following checks are still failing:
     missing required label: "PR target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[IgorMinar]

thank you!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}