New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs to use HttpClientModule instead of HttpModule #22727
docs: update docs to use HttpClientModule instead of HttpModule #22727
Conversation
Hi @agussman! This PR has merge conflicts due to recent upstream merges. |
2 similar comments
Hi @agussman! This PR has merge conflicts due to recent upstream merges. |
Hi @agussman! This PR has merge conflicts due to recent upstream merges. |
@agussman : Hi. Now that v6 is released, we're getting around to closing some open loops. I apologize for letting this sit for so long. If you're still interested, we'd be thrilled to have you contribute this fix. It's a bit out-of-date, as I think some PRs were merged that fixed some of the HTTPModule issues you were addressing. I think, however, there are still some areas that aren't fixed. I made a few notes on the original issue. Is there anything I can do to help you make this contribution? Thanks! |
@jenniferfell : Yes, I would like to contribute the PR. What is required from my end? |
@agussman: Fantastic! The first thing I recommend doing is resolving conflicts between what we have in master and what you have in this PR. We just released v6 yesterday, so it's a good time. If you're familiar with github, there's nothing special about doing this with our example and doc files. For some tips about how we merge changes from master into our doc-examples branches, my team started to collect some information: |
7e11568
to
8ba2159
Compare
Hi @jenniferfell : I merged in the latest master, resolved conflicts, and updated the PR. Can you take a look and let me know if there are any issues that would prevent it from being merged? Thanks! |
8ba2159
to
53a1348
Compare
Updated most examples to use HttpClientModule instead of deprecated HttpModule fix angular#19280
53a1348
to
4d33477
Compare
@IgorMinar Thank you for the code review! @jenniferfell Anything else needed from me? |
caretaker note: the failing CI tests seems like an unrelated flake. I restarted the job, but if that doesn't help please check on the failure and merge this PR. @agussman I don't think so. I think the CI failure is unrelated to your change, so let's wait for the caretaker to investigate. |
@agussman there is an issue with the changes causing the CI to fail. Could you please take a look. |
@vicb: Happy to take a look, but per @IgorMinar's comment the CI failures don't appear to be related to these changes. |
@agussman, there are still files that are importing from (We also nee to make sure that guide text is update (if necessary).) |
@agussman will you rebase on master? |
Closing in favor of smaller PRs already merged and in process |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updated most examples to use HttpClientModule instead of deprecated HttpModule
fix #19280
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19280
What is the new behavior?
Updated doc examples to use
HttpClientModule
instead of oldHttpModule
.Does this PR introduce a breaking change?
Other information