New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ivy): document project status #22751
Conversation
Moves the status reporting from the issue angular#21706 to a file that can be updated as changes are being made. This addresses one of the comments on the issue and allows better tracking of updates to this status and changes made.
You can preview 0c10d00 at https://pr22751-0c10d00.ngbuilds.io/. |
## Annotations | ||
| Annotation | `defineXXX()` | Run time | Spec | Compiler | Back Patch | | ||
| -------------------- | ------------------------------ | ------- | -------- | -------- | -------- | | ||
| `@Component` | ✅ `defineComponent()` | ✅ | ✅ | ✅ | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true, non-element components are not yet supported:
angular/packages/core/src/render3/instructions.ts
Lines 449 to 452 in bd9d4df
const name = isHostElement ? hostComponentDef !.tag : nameOrComponentType as string; | |
if (name === null) { | |
// TODO: future support for nameless components. | |
throw 'for now name is required'; |
| `<div title="Hello {{name}}!">` | ✅ | ✅ | ✅ | | ||
| `<div [attr.value]="exp">` | ✅ | ✅ | ❌ | | ||
| `<div class="literal">` | ✅ | ✅ | ✅ | | ||
| `<div [class]="exp">` | ❌ | ❌ | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhevery update class and syle (runtime & spec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a direct copy from the issue. If the issue has been updated we should make the fixes here before commit. However, we should commit a version that matches the issue first and then submit follow-up PRs to fix the content.
Moves the status reporting from the issue angular#21706 to a file that can be updated as changes are being made. This addresses one of the comments on the issue and allows better tracking of updates to this status and changes made. PR Close angular#22751
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Moves the status reporting from the issue #21706 to a file that
can be updated as changes are being made. This addresses one of the
comments on the issue and allows better tracking of updates to this
status and changes made.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21706
Updates to the status cannot be tracked to commits that implement the feature.
What is the new behavior?
Commits that affect the status can now include the status update in the commit.
Does this PR introduce a breaking change?