Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ivy): document project status #22751

Closed
wants to merge 1 commit into from

Conversation

chuckjaz
Copy link
Contributor

Moves the status reporting from the issue #21706 to a file that
can be updated as changes are being made. This addresses one of the
comments on the issue and allows better tracking of updates to this
status and changes made.

PR Type

What kind of change does this PR introduce?

[x] Documentation content changes

What is the current behavior?

Issue Number: #21706

Updates to the status cannot be tracked to commits that implement the feature.

What is the new behavior?

Commits that affect the status can now include the status update in the commit.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Moves the status reporting from the issue angular#21706 to a file that
can be updated as changes are being made. This addresses one of the
comments on the issue and allows better tracking of updates to this
status and changes made.
@mary-poppins
Copy link

You can preview 0c10d00 at https://pr22751-0c10d00.ngbuilds.io/.

## Annotations
| Annotation | `defineXXX()` | Run time | Spec | Compiler | Back Patch |
| -------------------- | ------------------------------ | ------- | -------- | -------- | -------- |
| `@Component` | ✅ `defineComponent()` | ✅ | ✅ | ✅ | ❌ |
Copy link
Contributor

@trotyl trotyl Mar 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true, non-element components are not yet supported:

const name = isHostElement ? hostComponentDef !.tag : nameOrComponentType as string;
if (name === null) {
// TODO: future support for nameless components.
throw 'for now name is required';

@chuckjaz chuckjaz added the target: major This PR is targeted for the next major release label Mar 14, 2018
@chuckjaz chuckjaz requested a review from mhevery March 14, 2018 15:56
| `<div title="Hello {{name}}!">` | ✅ | ✅ | ✅ |
| `<div [attr.value]="exp">` | ✅ | ✅ | ❌ |
| `<div class="literal">` | ✅ | ✅ | ✅ |
| `<div [class]="exp">` | ❌ | ❌ | ❌ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhevery update class and syle (runtime & spec)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a direct copy from the issue. If the issue has been updated we should make the fixes here before commit. However, we should commit a version that matches the issue first and then submit follow-up PRs to fix the content.

@kara kara added the comp: ivy label Mar 14, 2018
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Mar 16, 2018
@mhevery mhevery closed this in cedc04c Mar 16, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
Moves the status reporting from the issue angular#21706 to a file that
can be updated as changes are being made. This addresses one of the
comments on the issue and allows better tracking of updates to this
status and changes made.

PR Close angular#22751
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants