Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): double size of DI bloom filter #22775

Closed
wants to merge 1 commit into from
Closed

refactor(ivy): double size of DI bloom filter #22775

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Mar 14, 2018

This PR doubles the size of the bloom filter, which should help speed up DI (fewer false positives).

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy target: major This PR is targeted for the next major release refactoring Issue that involves refactoring or code-cleanup labels Mar 14, 2018
@kara kara requested a review from mhevery March 14, 2018 20:34
@mary-poppins
Copy link

You can preview 2af937d at https://pr22775-2af937d.ngbuilds.io/.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 15, 2018
@kara
Copy link
Contributor Author

kara commented Mar 15, 2018

presubmit

@kara kara added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2018
@mhevery mhevery closed this in 4e6ac18 Mar 15, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@kara @leo6104
refactor(ivy): double size of DI bloom filter (angular#22775)
472e3a6 
PR Close angular#22775
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kara @mary-poppins @mhevery @googlebot