Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable inlineHelpers in tsconfig #22812

Closed
wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

This is the primary tsconfig file used for Bazel builds.
Previously, we enabled this option only for releases.

@mary-poppins
Copy link

You can preview 165086b at https://pr22812-165086b.ngbuilds.io/.

This is the primary tsconfig file used for Bazel builds.
Previously, we enabled this option only for releases.
@mary-poppins
Copy link

You can preview 81aeacc at https://pr22812-81aeacc.ngbuilds.io/.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins
Copy link

You can preview 3e837c1 at https://pr22812-3e837c1.ngbuilds.io/.

@IgorMinar IgorMinar added cla: yes area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed cla: no labels Mar 16, 2018
@IgorMinar
Copy link
Contributor

caretaker note: ignore the CLA warning.

@ngbot
Copy link

ngbot bot commented Mar 16, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery mhevery closed this in f9247e4 Mar 16, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
This is the primary tsconfig file used for Bazel builds.
Previously, we enabled this option only for releases.

PR Close angular#22812
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
This is the primary tsconfig file used for Bazel builds.
Previously, we enabled this option only for releases.

PR Close angular#22812
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants