refactor(ivy): allow unnecessary symbols to be tree-shaken out of hello world #22838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
changed the title
kara
added
action: review
|
You can preview a1d6d57 at https://pr22838-a1d6d57.ngbuilds.io/. |
|
You can preview 8353b5c at https://pr22838-8353b5c.ngbuilds.io/. |
mhevery
approved these changes
Mar 17, 2018
|
I think this needs to be rebased on master to get it green? |
kara
removed
the
action: review
|
You can preview eb71548 at https://pr22838-eb71548.ngbuilds.io/. |
kara
changed the title
mhevery
pushed a commit
that referenced
this pull request
Mar 18, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
May 12, 2018
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
May 12, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows some unnecessary symbols to be tree-shaken out of hello world by:
renderComponentOrTemplateinstead oftickfor first change detection from root (we don't need to loop up to the root component since we know we are there)directiveCreateinto a base version for root and an extended version for everywhere else