build(aio): update tsc, angular, cli and other dependencies #22872

IgorMinar · 2018-03-20T04:21:57Z

No description provided.

mary-poppins · 2018-03-20T06:58:41Z

You can preview d58f1d4 at https://pr22872-d58f1d4.ngbuilds.io/.

mary-poppins · 2018-03-20T07:39:04Z

You can preview 7c3e60f at https://pr22872-7c3e60f.ngbuilds.io/.

mary-poppins · 2018-03-20T08:13:39Z

You can preview bc9e172 at https://pr22872-bc9e172.ngbuilds.io/.

googlebot · 2018-03-20T16:23:25Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

alfaproject · 2018-03-21T07:27:12Z

aio/src/app/custom-elements/code/code.component.spec.ts

      // presence of `<li>`s are a tell-tale for line numbers
+      await new Promise(resolve => hostComponent.codeComponent.codeFormatted.subscribe(resolve));


Would codeFormatted.toPromise() work?

I don't think so. AFAICT, toPromise() only resolves once the observable completes, but we just want to catch the next "emission". codeFormatted.pipe(first()).toPromise() probably would though 😁

Yup only when it completes :F

mary-poppins · 2018-03-21T14:06:22Z

You can preview 4e011af at https://pr22872-4e011af.ngbuilds.io/.

mary-poppins · 2018-03-21T15:01:26Z

You can preview d31b3f3 at https://pr22872-d31b3f3.ngbuilds.io/.

mary-poppins · 2018-03-21T15:04:18Z

You can preview 76fcd6e at https://pr22872-76fcd6e.ngbuilds.io/.

gkalpak · 2018-03-21T15:11:36Z

Travis build for upgrading to rxjs[-compat]@6.0.0-beta.1: 356403013
Travis build for switching to pipeable operators: 356403557
Travis build for removing rxjs-compat: 356404096

Removing rxjs-compat fails due to @angular/service-worker and @angular/material.
@angular/service-worker issues should be fixed after upgrading to the latest version (#19795).
Not sure about @angular/material.

gkalpak · 2018-03-23T12:52:19Z

aio/tools/ng-packages-installer/index.js

@@ -169,7 +169,6 @@ class NgPackagesInstaller {
    // FIXME: Temporarily use RxJS from root `node_modules/`.
    if (peerDependencies.rxjs) {
      peerDependencies.rxjs = `file:${ANGULAR_ROOT_DIR}/node_modules/rxjs`;


Are there still local changes in angular/node_modules/rxjs/, or can we get rid of this too?

PR Close #22872

we should not longer need it. PR Close #22872

PR Close angular#22872

…ar#22872) PR Close angular#22872

we should not longer need it. PR Close angular#22872

angular-automatic-lock-bot · 2019-09-13T11:21:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Mar 20, 2018

IgorMinar force-pushed the aio/angular-updates branch from f40f346 to 531616f Compare March 20, 2018 06:24

IgorMinar added comp: aio target: major This PR is targeted for the next major release labels Mar 20, 2018

IgorMinar changed the title ~~build(aio): update to @angular/cli@1.7.3~~ build(aio): update tsc, angular, cli and other dependencies Mar 20, 2018

googlebot added cla: no and removed cla: yes labels Mar 20, 2018

alfaproject reviewed Mar 21, 2018

View reviewed changes

IgorMinar added 7 commits March 21, 2018 13:08

build(aio): update to @angular/cli@1.7.3

778c284

fixup! build(aio): update to @angular/cli@1.7.3

3bc3a38

build(aio): update to @angular/core@6.0.0-beta.8

eacf1ef

build(aio): update to typescript@2.7.2

f7466f6

fixup! build(aio): update to @angular/core@6.0.0-beta.8

20e21b4

fixup! build(aio): update to typescript@2.7.2

9d9937f

fixup! build(aio): update to typescript@2.7.2

21e6dba

gkalpak force-pushed the aio/angular-updates branch 2 times, most recently from d1424d3 to 4e011af Compare March 21, 2018 13:48

gkalpak added 3 commits March 21, 2018 16:18

build(aio): upgrade @angular/* to 6.0.0-rc.0

be43534

build(aio): upgrade rxjs to 6.0.0-beta.0

d8e12b2

fixup! build(aio): update to typescript@2.7.2

fd3d08b

gkalpak force-pushed the aio/angular-updates branch from 4e011af to d31b3f3 Compare March 21, 2018 14:45

gkalpak force-pushed the aio/angular-updates branch from 76fcd6e to 6b4d938 Compare March 21, 2018 15:09

gkalpak approved these changes Mar 23, 2018

View reviewed changes

gkalpak mentioned this pull request Mar 23, 2018

Angular tutorial, InMemoryWebApiModule doesn't work with angular-in-memory-web-api 0.6.0 #22955

Closed

IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 23, 2018

matsko added cla: yes and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note cla: no labels Mar 23, 2018

matsko closed this in 07e9969 Mar 23, 2018

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): update to @angular/core@6.0.0-beta.8 (#22872)

56e5457

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): update to typescript@2.7.2 (#22872)

328511b

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): upgrade @angular/* to 6.0.0-rc.0 (#22872)

7681005

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): upgrade rxjs to 6.0.0-beta.0 (#22872)

53227ab

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

test(aio): minor improvements (#22872)

91503e5

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): upgrade rxjs to 6.0.0-beta.1 (#22872)

da76db9

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

refactor(aio): switch to pipeable RxJS operators (#22872)

01d2dd2

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): update examples to angular-in-memory-web-api@0.6.0 (#22872)

0f88fc7

PR Close #22872

matsko pushed a commit that referenced this pull request Mar 23, 2018

build(aio): remove rxjs-compat dependency from examples (#22872)

3a30f5d

we should not longer need it. PR Close #22872

IgorMinar mentioned this pull request Mar 23, 2018

angular.io improvements #21710

Closed

34 tasks

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): update to @angular/cli@1.7.3 (angular#22872)

f2eb8fb

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): update to @angular/core@6.0.0-beta.8 (angular#22872)

efe9ace

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): update to typescript@2.7.2 (angular#22872)

28d16f1

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): upgrade @angular/* to 6.0.0-rc.0 (angular#22872)

419c9c0

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): upgrade rxjs to 6.0.0-beta.0 (angular#22872)

7d36aba

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

test(aio): minor improvements (angular#22872)

b01bed5

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): upgrade rxjs to 6.0.0-beta.1 (angular#22872)

a69991d

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

refactor(aio): switch to pipeable RxJS operators (angular#22872)

0f29432

PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): update examples to angular-in-memory-web-api@0.6.0 (angul…

49baaee

…ar#22872) PR Close angular#22872

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): remove rxjs-compat dependency from examples (angular#22872)

aa83753

we should not longer need it. PR Close angular#22872

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(aio): update tsc, angular, cli and other dependencies #22872

build(aio): update tsc, angular, cli and other dependencies #22872

IgorMinar commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

googlebot commented Mar 20, 2018

alfaproject Mar 21, 2018

gkalpak Mar 21, 2018 •

edited

alfaproject Mar 21, 2018

mary-poppins commented Mar 21, 2018

mary-poppins commented Mar 21, 2018

mary-poppins commented Mar 21, 2018

gkalpak commented Mar 21, 2018 •

edited

gkalpak Mar 23, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

		// presence of `<li>`s are a tell-tale for line numbers
		await new Promise(resolve => hostComponent.codeComponent.codeFormatted.subscribe(resolve));

build(aio): update tsc, angular, cli and other dependencies #22872

build(aio): update tsc, angular, cli and other dependencies #22872

Conversation

IgorMinar commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

mary-poppins commented Mar 20, 2018

googlebot commented Mar 20, 2018

alfaproject Mar 21, 2018

Choose a reason for hiding this comment

gkalpak Mar 21, 2018 • edited

Choose a reason for hiding this comment

alfaproject Mar 21, 2018

Choose a reason for hiding this comment

mary-poppins commented Mar 21, 2018

mary-poppins commented Mar 21, 2018

mary-poppins commented Mar 21, 2018

gkalpak commented Mar 21, 2018 • edited

gkalpak Mar 23, 2018

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 13, 2019

gkalpak Mar 21, 2018 •

edited

gkalpak commented Mar 21, 2018 •

edited