Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify docs match examples updates for rxjs@6.0.0-alpha.4 #22890

Closed
jenniferfell opened this issue Mar 20, 2018 · 3 comments
Closed

Verify docs match examples updates for rxjs@6.0.0-alpha.4 #22890

jenniferfell opened this issue Mar 20, 2018 · 3 comments
Assignees
Labels
freq4: critical target: major This PR is targeted for the next major release type: bug/fix

Comments

@jenniferfell
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ X ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Doc text matches old examples

Expected behavior

Ensure doc text matches updated examples in PR #22573

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Ensure doc text matches what is shown in the codesnippets pulled from the examples

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2018
@jenniferfell jenniferfell added comp: docs type: bug/fix freq4: critical target: major This PR is targeted for the next major release labels Mar 20, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 20, 2018
@jenniferfell jenniferfell modified the milestones: Backlog, v6.0 Mar 20, 2018
@jenniferfell
Copy link
Contributor Author

@jbogarthyde Opening an issue so we can easily link this doc update request (and doc update PR) to the original examples update PR.

@IgorMinar IgorMinar modified the milestones: v6.0, v6-candidates Mar 23, 2018
@IgorMinar
Copy link
Contributor

I believe that this is done and can be closed. if not please reopen.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freq4: critical target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants