Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ts-api-guardian reuses root node_modules #22894

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

This avoids the need to run bazel run :install instead of yarn install.
We merge the devDependencies of ts-api-guardian into the root package.json file.

@alexeagle alexeagle force-pushed the easier_install branch 3 times, most recently from e95ad06 to 283fa88 Compare March 22, 2018 16:20
@alexeagle alexeagle requested review from andrewseguin and removed request for IgorMinar March 22, 2018 16:26
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Mar 22, 2018
@matsko matsko added the area: build & ci Related the build and CI infrastructure of the project label Mar 22, 2018
@andrewseguin
Copy link
Contributor

Looks good to me (as far as I can tell)

This avoids the need to run bazel run :install instead of yarn install.
We merge the devDependencies of ts-api-guardian into the root package.json file.
@alexeagle alexeagle added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker and removed target: major This PR is targeted for the next major release labels Mar 22, 2018
@matsko matsko closed this in 3498106 Mar 22, 2018
@alexeagle alexeagle deleted the easier_install branch March 22, 2018 23:47
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
This avoids the need to run bazel run :install instead of yarn install.
We merge the devDependencies of ts-api-guardian into the root package.json file.

PR Close angular#22894
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants