fix(ivy): fix type error in newer version of TS #22897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of TS is stricter about types and flags counter-variant types in some situations. This change inlines the DirectiveDefArgs into the arguments which: 1) removes the inheritance which caused the issue and 2) Makes it more friendly to IDEs since they will not report comments. Closes angular#22877 Closes angular#22843
kara
approved these changes
Mar 20, 2018
| /** | ||
| * A list of optional features to apply. | ||
| * | ||
| * See: {@link NgOnChancesFeature}, {@link PublicFeature} |
IgorMinar
added
the
action: cleanup
mhevery
removed
the
action: cleanup
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
Newer version of TS is stricter about types and flags counter-variant types in some situations. This change inlines the DirectiveDefArgs into the arguments which: 1) removes the inheritance which caused the issue and 2) Makes it more friendly to IDEs since they will not report comments. Closes angular#22877 Closes angular#22843 PR Close angular#22897
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of TS is stricter about types and flags counter-variant
types in some situations. This change inlines the DirectiveDefArgs
into the arguments which:
Closes #22877
Closes #22843
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information