build(bazel): add entry_point_name attr to ng_package #22963
Conversation
|
You can preview a648fcc at https://pr22963-a648fcc.ngbuilds.io/. |
| # If an explicit entry_point_name is given, use that. | ||
| if entry_point_name: | ||
| return entry_point_name | ||
| else: |
There was a problem hiding this comment.
now that it's an if-else construct, I think it would be better to replace the line below too
if entry_point_name:
...
elsif entry_point.find("/") >= 0:
...
else:
return name
| @@ -258,6 +258,9 @@ NG_PACKAGE_ATTRS = dict(NPM_PACKAGE_ATTRS, **dict(ROLLUP_ATTRS, **{ | |||
| "include_devmode_srcs": attr.bool(default = False), | |||
| "readme_md": attr.label(allow_single_file = FileType([".md"])), | |||
| "globals": attr.string_dict(default={}), | |||
| "entry_point_name": attr.string( | |||
| doc = "Name to use when generating bundle files for the primary entry-point.", | |||
There was a problem hiding this comment.
ooh, we need to do this for all the attributes and then make skydoc do the right thing to generate the API docs
There was a problem hiding this comment.
Was this what triggered to to go down a skydoc rabbit hole?
There was a problem hiding this comment.
I think so? was a long time ago
| @@ -278,11 +281,15 @@ NG_PACKAGE_ATTRS = dict(NPM_PACKAGE_ATTRS, **dict(ROLLUP_ATTRS, **{ | |||
| # Currently we just borrow the entry point for this, if it looks like | |||
| # some/path/to/my/package/index.js | |||
| # we assume the files should be named "package.*.js" | |||
| def primary_entry_point_name(name, entry_point): | |||
| return entry_point.split("/")[-2] if entry_point.find("/") >=0 else name | |||
| def primary_entry_point_name(name, entry_point, entry_point_name): | |||
There was a problem hiding this comment.
this was only a separate function because I needed to call it from somewhere else. now it looks like we should inline this into ng_package_outputs()
There was a problem hiding this comment.
It's good how it is; smaller, more focused functions are always better.
jelbourn
force-pushed
the
ng_package_entry_point_name
branch
from
a648fcc
to
0982876
Compare
|
You can preview 0982876 at https://pr22963-0982876.ngbuilds.io/. |
|
@alexeagle any other comments? |
|
nope merge it |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@alexeagle not sure if this warrants adding a separate gold setup since I don't think we want to apply this option to the existing example package. I also suspect this attr could be potentially replaced down the road with more intelligence in the rule.