ci(compiler-cli): run compiler-cli tests in bazel #22997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview a0dbd97 at https://pr22997-a0dbd97.ngbuilds.io/. |
alxhub
approved these changes
Mar 26, 2018
| if (isInBazel()) { | ||
| const support = setup(); | ||
| write = (fileName: string, content: string) => { support.write(fileName, content); }; | ||
| write('tsconfig-base.json', `{ |
There was a problem hiding this comment.
It seems like this file is the same - can it be moved down after the isInBazel switch?
|
You can preview f9eba8f at https://pr22997-f9eba8f.ngbuilds.io/. |
chuckjaz
force-pushed
the
bazel_compiler_cli_tests
branch
from
f9eba8f
to
6934782
Compare
|
You can preview 6934782 at https://pr22997-6934782.ngbuilds.io/. |
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tests for
@angular/compiler-clirun usingtest.shWhat is the new behavior?
Test for
@angualr/compiler-clirun usingbazel testDoes this PR introduce a breaking change?