ci(language-service): enable language service tests in bazel #23001
Conversation
|
You can preview b920e9d at https://pr23001-b920e9d.ngbuilds.io/. |
chuckjaz
force-pushed
the
bazel_language_service_tests_2
branch
from
b920e9d
to
6e63233
Compare
chuckjaz
added
target: major
|
You can preview 6e63233 at https://pr23001-6e63233.ngbuilds.io/. |
| @@ -512,6 +512,9 @@ class PipesTable implements SymbolTable { | |||
| values(): Symbol[] { return this.pipes.map(pipe => new PipeSymbol(pipe, this.context)); } | |||
| } | |||
|
|
|||
| // This matches .d.ts files that look like ".../<package-name>/<package-name>.d.ts", | |||
| const INDEX_PATTERN = /[\\|/](\w+)[\\|/]\1\.d\.ts$/; | |||
There was a problem hiding this comment.
funny thing: you do not match package-name :)
There was a problem hiding this comment.
/(?:\\|/)(\w+)(?:\\|/)\1\.d\.ts$/;
There was a problem hiding this comment.
I am not sure what you are asking. I need to match /foo/foo.d.ts but not /foo/bar.d.ts.
| if (isInBazel()) { | ||
| const support = setup(); | ||
| this.angularPath = path.join(support.basePath, 'node_modules/@angular'); | ||
| this.nodeModulesPath = path.join(support.basePath, 'node_modules'); |
There was a problem hiding this comment.
compute the second one first and .join('@angular') ?
| this.angularPath = path.join(support.basePath, 'node_modules/@angular'); | ||
| this.nodeModulesPath = path.join(support.basePath, 'node_modules'); | ||
| } else { | ||
| let angularIndex = moduleFilename.indexOf('@angular'); |
| if (angularIndex >= 0) | ||
| this.angularPath = | ||
| moduleFilename.substr(0, angularIndex).replace('/all/', '/all/@angular/'); | ||
| let distIndex = moduleFilename.indexOf('/dist/all'); |
| const p = type.filePath as string; | ||
| const m = p.match(INDEX_PATTERN); | ||
| if (m) { | ||
| const indexVersion = path.join(p.substr(0, m.index ! + m[1].length + 1), 'index.d.ts'); |
There was a problem hiding this comment.
I find path.join(path.basename(p) + 'index.d.ts'; easier to understand
|
You can preview 04cc32a at https://pr23001-04cc32a.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tests for
@angular/language-serviceonly run intest.sh.What is the new behavior?
Tests for
@angular/language-serviceinbazel test.Does this PR introduce a breaking change?