Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): Emit metadata.json under Blaze #23049

Closed
wants to merge 1 commit into from
Closed

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 28, 2018

This commit modifies the compilation to emit metadata.json files when
compiled under Blaze. The default behavior of ngc is to emit metadata
only when the --flatModuleOutFile flag is specified, but this mode
is not used in Blaze.
Emitting metadata for individual Angular components is needed for
Angular Language Service to work with projects compiled with Blaze.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Metadata.json files not emitted when compiled under Blaze.

Issue Number: N/A

What is the new behavior?

Emit metadata.json for individual Angular components in Blaze.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, would be nice to get Chuck to take a look too

@kyliau kyliau force-pushed the ngc branch 5 times, most recently from e58035d to e123648 Compare March 30, 2018 17:32
This commit modifies the compilation to emit metadata.json files when
compiled under Blaze. The default behavior of ngc is to emit metadata
only when the --flatModuleOutFile flag is specified, but this mode
is not used in Blaze.
Emitting metadata for individual Angular components is needed for
Angular Language Service to work with projects compiled with Blaze.
@vikerman vikerman added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 30, 2018
@vikerman vikerman removed the request for review from chuckjaz March 30, 2018 18:24
@alxhub alxhub closed this in 0c4e371 Mar 30, 2018
@kyliau kyliau deleted the ngc branch March 30, 2018 23:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants