Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update PERF_NOTES.md #23050

Closed
wants to merge 1 commit into from
Closed

docs: update PERF_NOTES.md #23050

wants to merge 1 commit into from

Conversation

avatsaev
Copy link
Contributor

@avatsaev avatsaev commented Mar 28, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@avatsaev avatsaev changed the title Update PERF_NOTES.md chore: update PERF_NOTES.md Mar 28, 2018
@vicb vicb added action: merge The PR is ready for merge by the caretaker comp: docs target: major This PR is targeted for the next major release labels Mar 29, 2018
@ngbot
Copy link

ngbot bot commented Mar 29, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Mar 29, 2018
@vicb
Copy link
Contributor

vicb commented Mar 29, 2018

Please fix:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

@avatsaev
Copy link
Contributor Author

avatsaev commented Mar 29, 2018

Oops sorry my bad, updated. :)

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Apr 3, 2018
@ngbot
Copy link

ngbot bot commented Apr 3, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb
Copy link
Contributor

vicb commented Apr 3, 2018

Thanks !

@avatsaev avatsaev changed the title chore: update PERF_NOTES.md docs: update PERF_NOTES.md Apr 4, 2018
@alxhub alxhub closed this in cae48df Apr 4, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants