Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to rxjs@6.0.0-beta.4 #23084

Closed
wants to merge 8 commits into from
Closed

build: update to rxjs@6.0.0-beta.4 #23084

wants to merge 8 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@mary-poppins
Copy link

You can preview 1a8e6df at https://pr23084-1a8e6df.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4a005ec at https://pr23084-4a005ec.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4c545d7 at https://pr23084-4c545d7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f40b64f at https://pr23084-f40b64f.ngbuilds.io/.

@IgorMinar
Copy link
Contributor Author

IgorMinar commented Mar 30, 2018 •
edited

the @rxjs/operators dependencies are needed because of https://github.com/ReactiveX/rxjs/pull/3481/files - I'm not sure if that was intentional though... @alexeagle ?

if it was intentional, how come I don't need to declare the dependency everywhere? e.g. in router/BUILD.bazel.

@mary-poppins
Copy link

You can preview 04367e3 at https://pr23084-04367e3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 20ce4ef at https://pr23084-20ce4ef.ngbuilds.io/.

@IgorMinar IgorMinar added the target: major This PR is targeted for the next major release label Mar 30, 2018
@mary-poppins
Copy link

You can preview 84be7b0 at https://pr23084-84be7b0.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2018
@IgorMinar IgorMinar closed this in 6f7d140 Mar 30, 2018
IgorMinar added a commit that referenced this pull request Mar 30, 2018
@IgorMinar
build: update to zone.js@0.8.20 (#23084)
3603a10 
PR Close #23084
IgorMinar added a commit that referenced this pull request Mar 30, 2018
@IgorMinar
test: remove obsolete typings tests (#23084)
7fdc24d 
we no longer support typescript 2.4, 2.5, and 2.6

PR Close #23084
IgorMinar added a commit that referenced this pull request Mar 30, 2018
@IgorMinar
test: add typings test for typescript 2.7 (#23084)
dc95e7b 
PR Close #23084
IgorMinar added a commit that referenced this pull request Mar 30, 2018
@IgorMinar
test: add missing lockfile for integration/ng_update test (#23084)
88a93e7 
PR Close #23084
IgorMinar added a commit that referenced this pull request Mar 30, 2018
@IgorMinar
build: add missing dependencies on @rxjs//operators needed for rxjs@6…
22cb2c9 
….0.0-beta.4 (#23084)

PR Close #23084
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@IgorMinar
build: update to rxjs@6.0.0-beta.4 (angular#23084)
79c6f02 
PR Close angular#23084
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@IgorMinar
build: add missing dependencies on @rxjs//operators needed for rxjs@6…
9ddfb4f 
….0.0-beta.4 (angular#23084)

PR Close angular#23084
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IgorMinar @mary-poppins @alexeagle @googlebot