Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ngbot config for L1 triage #23086

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Mar 30, 2018

PR Type

What kind of change does this PR introduce?

[x] CI related changes

What is the current behavior?

No config for L1 triage

Issue Number: #23072

What is the new behavior?

Added config for L1 triage, and refactored parameter name for L2 triage

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ngbot labels Mar 30, 2018
@ocombe ocombe requested a review from alexeagle March 30, 2018 13:22
@manughub
Copy link
Contributor

Need to think through the state of an issue once L2 triage is done so we dont keep going back and forth. Will update. Pls hold off on merging this. I'll update the outcome here.

@ocombe ocombe added state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2018
@manughub
Copy link
Contributor

manughub commented Apr 3, 2018

Summary of what we'll need: @ocombe

A new issue/feature-request that gets logged (ie that does not yet have comp), will not get a milestone.

An open issue that has a comp and is missing either severity, type or freq will have a milestone:needsTriage.
An open feature request that has a comp and is missing type (freq and severity are not applicable for feature) will have milestone:needsTriage.

Once an issue has comp, type, severity and freq then its milestone:backlog
Once a feature has comp, type type then its milestone:backlog

@ocombe ocombe added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Apr 6, 2018
@IgorMinar IgorMinar closed this in 0fba9a6 Apr 6, 2018
@ocombe ocombe deleted the feat/ngbot/L1-triage branch April 10, 2018 11:32
@manughub
Copy link
Contributor

Seems to be working fine, however the updates prior to this PR have left some of the issues in an inconsistent state. Looks like the bot is not crawling the full set of issues to do a clean up based on changes we made.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants