refactor(ivy): generate pipe names instead of defs #23104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Ivy compiler to generate pipe names instead of defs.
Original template:
Before:
After:
Notes:
We used to have an optimization where we passed the first instance of a pure pipe to any subsequent invocations of that pipe, to avoid having to instantiate it multiple times. Now that the compiler is generating code as if it doesn't know which pipes are present in the template (and thus which ones are pure and should get an instance), it no longer makes sense to generate this extra argument.
Once test(ivy): create todo app in ivy #22921 goes in, we'll want to refactor to share the
addDependencyToComponent
logic.