Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to rxjs@6.0.0-rc.0 #23106

Closed
wants to merge 2 commits into from
Closed

build: update to rxjs@6.0.0-rc.0 #23106

wants to merge 2 commits into from

Conversation

IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar commented Mar 31, 2018 •
edited

No description provided.

@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Mar 31, 2018
@mary-poppins
Copy link

You can preview 963e11e at https://pr23106-963e11e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 913e711 at https://pr23106-913e711.ngbuilds.io/.

@IgorMinar IgorMinar force-pushed the build/rxjs-v6rc0 branch 2 times, most recently from 5ca51d3 to 963788a Compare March 31, 2018 14:24
@mary-poppins
Copy link

You can preview 5ca51d3 at https://pr23106-5ca51d3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 963788a at https://pr23106-963788a.ngbuilds.io/.

alexeagle
alexeagle approved these changes Apr 2, 2018
View reviewed changes
aio/scripts/_payload-limits.json
@@ -3,7 +3,7 @@
"master": {
"uncompressed": {
"inline": 1971,
"main": 567849,
"main": 565539,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes me cry so much that this is checked into VCS, I can't wait to switch to buildsize.org - @Toxicable we need the red status to be posted to PRs so that we can switch!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I have time this weekend! It's near my top priority

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't mind that much, but I'll never say no to an improved workflow as long as it helps us to effectively catch size regressions

@mary-poppins
Copy link

You can preview 50dbada at https://pr23106-50dbada.ngbuilds.io/.

@IgorMinar
build(aio): update to rxjs@6.0.0-rc.0
e7071fa 
-rw-r--r--  1 iminar  primarygroup    2774 Mar 30 17:23 dist/announcement-bar.module.94664978458f4bcdad0e.chunk.js
-rw-r--r--  1 iminar  primarygroup    8081 Mar 30 17:23 dist/api-list.module.0080b5cc2e6a0e0cb4e0.chunk.js
-rw-r--r--  1 iminar  primarygroup    3963 Mar 30 17:23 dist/code-example.module.a71be2c11f00a30159ae.chunk.js
-rw-r--r--  1 iminar  primarygroup   29367 Mar 30 17:23 dist/code-tabs.module.91c45e5c6e7bc37a7ae3.chunk.js
-rw-r--r--  1 iminar  primarygroup   18647 Mar 30 17:23 dist/common.ba5d418531a81244d32a.chunk.js
-rw-r--r--  1 iminar  primarygroup    6719 Mar 30 17:23 dist/contributor-list.module.3f67eb8916b4b5d9553b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1009 Mar 30 17:23 dist/current-location.module.5b1b839219a3afa4821c.chunk.js
-rw-r--r--  1 iminar  primarygroup   10037 Mar 30 17:23 dist/expandable-section.module.e990983253a804b8680b.chunk.js
-rw-r--r--  1 iminar  primarygroup    1642 Mar 30 17:23 dist/file-not-found-search.module.3ebb2c728ee873e1124f.chunk.js
-rw-r--r--  1 iminar  primarygroup    1971 Mar 30 17:23 dist/inline.966da76300859bd75965.bundle.js
-rw-r--r--  1 iminar  primarygroup    5905 Mar 30 17:23 dist/live-example.module.db0fa04009ecb3863ec8.chunk.js
-rw-r--r--  1 iminar  primarygroup  565539 Mar 30 17:23 dist/main.4962a0cf09dd39042cdb.bundle.js
-rw-r--r--  1 iminar  primarygroup   40272 Mar 30 17:23 dist/polyfills.60722fb8dd6546cb465e.bundle.js
-rw-r--r--  1 iminar  primarygroup   14886 Mar 30 17:23 dist/prettify.04d149a0484032073703.chunk.js
-rw-r--r--  1 iminar  primarygroup    4840 Mar 30 17:23 dist/resource-list.module.7d9223ca5f7ae5ce9d48.chunk.js
-rw-r--r--  1 iminar  primarygroup   54001 Mar 30 17:23 dist/worker-basic.min.js
@IgorMinar
build: update to rxjs@6.0.0-rc.0
bd3b151
@mary-poppins
Copy link

You can preview bd3b151 at https://pr23106-bd3b151.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2018
@alxhub alxhub closed this in 62e6e21 Apr 3, 2018
alxhub pushed a commit that referenced this pull request Apr 3, 2018
@IgorMinar @alxhub
build: update to rxjs@6.0.0-rc.0 (#23106)
92724b3 
PR Close #23106
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@IgorMinar @alxhub
build: update to rxjs@6.0.0-rc.0 (angular#23106)
6509027 
PR Close angular#23106
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Toxicable Toxicable Toxicable left review comments

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @mary-poppins @alexeagle @Toxicable @googlebot