New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade zone.js #23108
build: upgrade zone.js #23108
Conversation
1e57798
to
2f60702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a lot of unrelated formatting changes in the source code. Could you revert those?
Thank you for looking into this.
.angulardoc.json
Outdated
@@ -0,0 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhevery , yes, I will revert it now.
edebbe2
to
d7fd35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change in zone.js that should be documented and require a minor version bump?
In other words do we expect others to have to make these changes as well? Should we update our testing docs?
@IgorMinar , I will update the test document now, about the break change such as user don't need to write |
af65100
to
b6c63cc
Compare
aio/package.json
Outdated
@@ -93,7 +93,7 @@ | |||
"rxjs-compat": "6.0.0-beta.4", | |||
"tslib": "^1.9.0", | |||
"web-animations-js": "^2.2.5", | |||
"zone.js": "^0.8.19" | |||
"zone.js": "git+https://github.com/JiaLiPassion/zone.js#newbundle2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be replaced to point to an npm release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkalpak , sure, if the g3
test passed, zone.js
will have a new release
package.json
Outdated
@@ -31,7 +31,7 @@ | |||
"reflect-metadata": "^0.1.3", | |||
"rxjs": "6.0.0-beta.4", | |||
"tslib": "^1.7.1", | |||
"zone.js": "^0.8.12" | |||
"zone.js": "git+https://github.com/JiaLiPassion/zone.js#newbundle2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be replaced to point to an npm release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above.
Removed the |
Hi @JiaLiPassion! This PR has merge conflicts due to recent upstream merges. |
439eb99
to
eea5c5b
Compare
🎉 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
based on #23100
Upgrade
zone.js
to latest version, currently this PR is just for test, because it depends on myzone.js branch
.in
zone.js
0.8.21, there are several feature which breakangular
test.async/fakeAsync
from angular to zone.jsjasmine.clock()
to be auto jump intofakeAsync
this feature break the test cases in
aio
. https://github.com/angular/angular/blob/master/aio/src/app/app.component.spec.ts#L1110which use
jasmine.clock()
to simulatetimer
, but still useasync/await
, so it will beTIMEOUT
, in this PR, just removeasync/await
and usetick
.angular
will be timeout, https://travis-ci.org/angular/angular/jobs/360448001the reason is because
zone.js AsyncTestZoneSpec
add a new feature to be able to waitnon resolved promise.then
, it seems this feature will have a big impact to currentangular
test cases, for example, in the following case,https://github.com/angular/angular/blob/master/packages/compiler/test/metadata_resolver_spec.ts#L87
current test case seems have some error, that the
promise.then
never invoked, but in earlier version ofzone.js
, this test case will pass, but inzone.js 0.8.21
, this will fail. there are several similar cases, so I just disable this feature in fix(fakeAsync): fix #1050, should only reset patched Date.now until fakeAsync exit zone.js#1051, and I will check all related test cases in angular later.