Fix extra rxjs symbols being retained in ivy demo #23131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
approved these changes
Apr 2, 2018
alfaproject
reviewed
Apr 3, 2018
| }, | ||
| { | ||
| "name": "__extends$6" | ||
| }, |
There was a problem hiding this comment.
Are these from tslib? o:
There was a problem hiding this comment.
I suppose so? It seems undesirable that there are several copies of this.
alexeagle
force-pushed
the
issue_172
branch
3 times, most recently
from
6d7b0be
to
7157acd
Compare
fixes the build on glinux.
this is needed to update to latest rules_nodejs due to breaking change in bazelbuild/rules_nodejs#172 It has the side-effect of correctly marking rxjs packages as side-effect-free
alxhub
pushed a commit
that referenced
this pull request
Apr 3, 2018
this is needed to update to latest rules_nodejs due to breaking change in bazelbuild/rules_nodejs#172 It has the side-effect of correctly marking rxjs packages as side-effect-free PR Close #23131
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.