Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update cli-hello-world to @angular/cli@6-rc0 and hello_world__closure to the latest closure compiler #23149

Closed
wants to merge 4 commits into from
Closed

test: update cli-hello-world to @angular/cli@6-rc0 and hello_world__closure to the latest closure compiler #23149

wants to merge 4 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@mary-poppins
Copy link

You can preview f0f332b at https://pr23149-f0f332b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview fc72b7a at https://pr23149-fc72b7a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 070bab5 at https://pr23149-070bab5.ngbuilds.io/.

@ngbot
Copy link

ngbot bot commented Apr 4, 2018

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@alxhub alxhub added area: testing Issues related to Angular testing features, such as TestBed area: build & ci Related the build and CI infrastructure of the project and removed area: testing Issues related to Angular testing features, such as TestBed labels Apr 4, 2018
@IgorMinar IgorMinar added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2018
alexeagle
alexeagle reviewed Apr 4, 2018
View reviewed changes
integration/_payload-limits.json
"polyfills": 60187
"runtime": 1110,
"main": 151765,
"polyfills": 59462
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am crying a lot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐤

alexeagle
alexeagle reviewed Apr 4, 2018
View reviewed changes
integration/hello_world__closure/package.json
@@ -10,7 +10,7 @@
"@angular/core": "file:../../dist/packages-dist/core",
"@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
"@angular/platform-server": "file:../../dist/packages-dist/platform-server",
"google-closure-compiler": "20171023.0.1",
"google-closure-compiler": "20180319.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @steveblue

@mary-poppins
Copy link

You can preview 9f1b3cb at https://pr23149-9f1b3cb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0862798 at https://pr23149-0862798.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 5, 2018
@ngbot
Copy link

ngbot bot commented Apr 5, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the target: major This PR is targeted for the next major release label Apr 5, 2018
@IgorMinar IgorMinar changed the title test: update cli-hello-world to @angular/cli@1.7.x test: update cli-hello-world to @angular/cli@6-rc0 and hello_world__closure to the latest closure compiler Apr 5, 2018
@IgorMinar IgorMinar closed this in 1aebee4 Apr 5, 2018
IgorMinar added a commit that referenced this pull request Apr 5, 2018
@IgorMinar
build: configure angular-cli projects to use yarn by default (#23149)
bf88c5c 
PR Close #23149
IgorMinar added a commit that referenced this pull request Apr 5, 2018
@IgorMinar
test: upgrade cli-hello-world to cli 6.0.0-rc.0 (#23149)
dae4689 
PR Close #23149
IgorMinar added a commit that referenced this pull request Apr 5, 2018
@IgorMinar
test: update hello_world__closure to google-closure-compiler@20180319…
7c03961 
….0.0 (#23149)

PR Close #23149
@mary-poppins
Copy link

You can preview d1dd217 at https://pr23149-d1dd217.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3f9929a at https://pr23149-3f9929a.ngbuilds.io/.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @mary-poppins @alexeagle @alxhub @googlebot