New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixed live example for the lifecycle hooks. #23201
docs: fixed live example for the lifecycle hooks. #23201
Conversation
@kapunahelewong, Can you please look into this, whats wrong with this PR, the first task failed. Is this something I missed? |
Hey @jainanuj0812 one of the docs team members will need to take care of that "Missing required label" for you, so you don't have to worry about that one. You'll just need to keep an eye on the circleci build and the travis build. If those fail, tag me and I'll be happy to take a look at the error logs. @jenniferfell is on the docs team and should be able to help you out with the required label. |
@kapunahelewong, Thank you again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but a better fix would be to change the logger.clear() to empty the existing array via logs.length = 0
- @jainanuj0812 would you consider submitting a change that does that and undoes this change?
@IgorMinar Sure, I am creating a new pull request with the suggested changes |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
Docs
What is the current behavior?
**https://angular.io/guide/lifecycle-hooks
Live example for lifecycle hooks in documentation is not working as expected.
Below is the example link
https://stackblitz.com/angular/jlqeyrgaoaq
Clicking the 'Create PeekABooComponent' not logging the lifecycle hooks below it on UI.**
Issue Number: 22279
What is the new behavior?
After clicking the 'Create PeekABooComponent' the logs should be viewed below it.
Does this PR introduce a breaking change?