Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed live example for the lifecycle hooks. #23201

Closed
wants to merge 1 commit into from
Closed

docs: fixed live example for the lifecycle hooks. #23201

wants to merge 1 commit into from

Conversation

jainanuj0812
Copy link
Contributor

@jainanuj0812 jainanuj0812 commented Apr 5, 2018

PR Type

Docs

Documentation content changes

What is the current behavior?

**https://angular.io/guide/lifecycle-hooks
Live example for lifecycle hooks in documentation is not working as expected.

Below is the example link
https://stackblitz.com/angular/jlqeyrgaoaq

Clicking the 'Create PeekABooComponent' not logging the lifecycle hooks below it on UI.**

Issue Number: 22279

What is the new behavior?

After clicking the 'Create PeekABooComponent' the logs should be viewed below it.

Does this PR introduce a breaking change?

No

@jainanuj0812
Copy link
Contributor Author

@kapunahelewong, Can you please look into this, whats wrong with this PR, the first task failed. Is this something I missed?

@kapunahelewong
Copy link
Contributor

Hey @jainanuj0812 one of the docs team members will need to take care of that "Missing required label" for you, so you don't have to worry about that one. You'll just need to keep an eye on the circleci build and the travis build. If those fail, tag me and I'll be happy to take a look at the error logs.

@jenniferfell is on the docs team and should be able to help you out with the required label.

@jainanuj0812
Copy link
Contributor Author

@kapunahelewong, Thank you again!

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but a better fix would be to change the logger.clear() to empty the existing array via logs.length = 0 - @jainanuj0812 would you consider submitting a change that does that and undoes this change?

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 5, 2018
@IgorMinar IgorMinar closed this in b5f41f2 Apr 5, 2018
IgorMinar pushed a commit that referenced this pull request Apr 5, 2018
@jainanuj0812
Copy link
Contributor Author

@IgorMinar Sure, I am creating a new pull request with the suggested changes

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants