Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecated @stable jsdoc tags #23210

Closed
wants to merge 3 commits into from

Conversation

petebacondarwin
Copy link
Member

No description provided.

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release type: docs labels Apr 5, 2018
@mary-poppins
Copy link

You can preview 4a4d633 at https://pr23210-4a4d633.ngbuilds.io/.

@IgorMinar
Copy link
Contributor

@petebacondarwin all the golden files for api tests need to be updated. can you please do that? thanks

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 10, 2018
These are no longer needed as stable docs are computed as those that
do not have `@experimental` or `@deprecated` tags.
This was not being picked up by the doc-gen as it does not appear to be
part of the public API.
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 10, 2018
@mary-poppins
Copy link

You can preview 2503163 at https://pr23210-2503163.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 572e027 at https://pr23210-572e027.ngbuilds.io/.

These are no longer needed as stable docs are computed as those that
do not have `@experimental` or `@deprecated` tags.
@mary-poppins
Copy link

You can preview 002e714 at https://pr23210-002e714.ngbuilds.io/.

@buildsize
Copy link

buildsize bot commented Apr 10, 2018

File name Previous Size New Size Change
bundle.min.js 39.94 KB 52.97 KB 13.02 KB (33%)
bundle.min.js.brotli 11.22 KB 14.14 KB 2.93 KB (26%)

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 11, 2018
@IgorMinar IgorMinar closed this in 4b96a58 Apr 11, 2018
IgorMinar pushed a commit that referenced this pull request Apr 11, 2018
This was not being picked up by the doc-gen as it does not appear to be
part of the public API.

PR Close #23210
@petebacondarwin petebacondarwin deleted the doc-stable branch April 11, 2018 07:57
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
These are no longer needed as stable docs are computed as those that
do not have `@experimental` or `@deprecated` tags.

PR Close angular#23210
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants