Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant override of robots meta #23249

Closed
wants to merge 1 commit into from
Closed

remove redundant override of robots meta #23249

wants to merge 1 commit into from

Conversation

amitport
Copy link
Contributor

@amitport amitport commented Apr 8, 2018 •
edited

according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

gkalpak
gkalpak reviewed Apr 12, 2018
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I guess we have both, because we originally handled them a little differently (ee here). There doesn't seem to be a need for both atm.

@IgorMinar, @petebacondarwin wdyt?

BTW, you also need to update other places modifying these tags (e.g. here - could be the only place; I haven't checked).

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: patch This PR is targeted for the next patch release labels Apr 12, 2018
@amitport
Copy link
Contributor Author

@gkalpak, I fixed to line you mentioned. Couldn't find any additional references.

petebacondarwin
petebacondarwin approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that now we don't do different behaviour for Google bot we can remove this.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2018
@ngbot
Copy link

ngbot bot commented Apr 13, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@amitport @IgorMinar
fix(aio): remove additional 'googlebot' reference
a65e557 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case
@IgorMinar IgorMinar closed this in c2a53bb Apr 13, 2018
IgorMinar pushed a commit that referenced this pull request Apr 13, 2018
@amitport @IgorMinar
fix(aio): remove additional 'googlebot' reference (#23249)
61bddeb 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close #23249
gkalpak added a commit to gkalpak/angular that referenced this pull request Apr 13, 2018
@gkalpak
test(aio): fix DocViewerComponent tests
856d4b1 
Obsolete assertions left over from angular#23249.
@gkalpak gkalpak mentioned this pull request Apr 13, 2018
Closed
gkalpak added a commit to gkalpak/angular that referenced this pull request Apr 13, 2018
@gkalpak
test(aio): fix DocViewerComponent tests
e0dd1f6 
Obsolete assertions left over from angular#23249.
IgorMinar pushed a commit that referenced this pull request Apr 13, 2018
@gkalpak @IgorMinar
test(aio): fix DocViewerComponent tests (#23359)
eac36d7 
Obsolete assertions left over from #23249.

PR Close #23359
IgorMinar pushed a commit that referenced this pull request Apr 13, 2018
@gkalpak @IgorMinar
test(aio): fix DocViewerComponent tests (#23359)
a3204f8 
Obsolete assertions left over from #23249.

PR Close #23359
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@amitport @wKoza
fix(aio): remove additional 'googlebot' reference (angular#23249)
ecf2415 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close angular#23249
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@gkalpak @wKoza
test(aio): fix DocViewerComponent tests (angular#23359)
683f94c 
Obsolete assertions left over from angular#23249.

PR Close angular#23359
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@amitport @wKoza
fix(aio): remove additional 'googlebot' reference (angular#23249)
dbf0a4e 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close angular#23249
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@gkalpak @wKoza
test(aio): fix DocViewerComponent tests (angular#23359)
624e790 
Obsolete assertions left over from angular#23249.

PR Close angular#23359
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@amitport @wKoza
fix(aio): remove additional 'googlebot' reference (angular#23249)
47304e5 
according to https://developers.google.com/search/reference/robots_meta_tag
googlebot is only used as a google specific override of 'robots'- there's no need for override in this case

PR Close angular#23249
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
@gkalpak @wKoza
test(aio): fix DocViewerComponent tests (angular#23359)
584afa2 
Obsolete assertions left over from angular#23249.

PR Close angular#23359
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amitport @petebacondarwin @IgorMinar @gkalpak @googlebot