Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reorder PACKAGE_GROUP entries to make @angular/core the first one #23303

Closed

Conversation

IgorMinar
Copy link
Contributor

CLI will soon consider the first entry to be the main entry in the package group.

This will then be used to display the main entry in "ng update" listing.

//cc: @hansl

CLI will soon consider the first entry to be the main entry in the package group.

This will then be used to display the main entry in "ng update" listing.
@IgorMinar IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project and removed area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 11, 2018
"core",
"bazel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit; add a comment so that when adding packages someone doesn’t change the order by mistake (since it looks alphabetical).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if we use buildifier at some point to format this file, it has a # do not sort comment (see other BAZEL.build files)
I'm surprised that CLI has this behavior (why would it should users @angular/core to mean all @angular packages?) but it's out of scope here

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2018
@ngbot
Copy link

ngbot bot commented Apr 12, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure forbidden label detected: PR action: review
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar closed this in 58faa0c Apr 12, 2018
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
…one (angular#23303)

CLI will soon consider the first entry to be the main entry in the package group.

This will then be used to display the main entry in "ng update" listing.

PR Close angular#23303
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
…one (angular#23303)

CLI will soon consider the first entry to be the main entry in the package group.

This will then be used to display the main entry in "ng update" listing.

PR Close angular#23303
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
…one (angular#23303)

CLI will soon consider the first entry to be the main entry in the package group.

This will then be used to display the main entry in "ng update" listing.

PR Close angular#23303
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants