New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: reorder PACKAGE_GROUP entries to make @angular/core the first one #23303
Conversation
CLI will soon consider the first entry to be the main entry in the package group. This will then be used to display the main entry in "ng update" listing.
tools/defaults.bzl
Outdated
"core", | ||
"bazel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit; add a comment so that when adding packages someone doesn’t change the order by mistake (since it looks alphabetical).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if we use buildifier at some point to format this file, it has a # do not sort
comment (see other BAZEL.build files)
I'm surprised that CLI has this behavior (why would it should users @angular/core
to mean all @angular
packages?) but it's out of scope here
…one (angular#23303) CLI will soon consider the first entry to be the main entry in the package group. This will then be used to display the main entry in "ng update" listing. PR Close angular#23303
…one (angular#23303) CLI will soon consider the first entry to be the main entry in the package group. This will then be used to display the main entry in "ng update" listing. PR Close angular#23303
…one (angular#23303) CLI will soon consider the first entry to be the main entry in the package group. This will then be used to display the main entry in "ng update" listing. PR Close angular#23303
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
CLI will soon consider the first entry to be the main entry in the package group.
This will then be used to display the main entry in "ng update" listing.
//cc: @hansl