Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(demo): fix typo in injected variable name #23315

Closed
wants to merge 1 commit into from

Conversation

jtheoof
Copy link
Contributor

@jtheoof jtheoof commented Apr 11, 2018

The service injected is ValueService, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the class being created.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Simple typo in the docs of angular.io.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 12, 2018
@ngbot
Copy link

ngbot bot commented Apr 12, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 12, 2018
@IgorMinar
Copy link
Contributor

caretaker note: can you update this pr with commit message: "docs: ..." rather than "docs(demo): ..."

@jtheoof
Copy link
Contributor Author

jtheoof commented Apr 12, 2018

sure thing. Should I be worried about the ci failures ? They seem unrelated to my changes.

The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.
@jtheoof
Copy link
Contributor Author

jtheoof commented Apr 12, 2018

Rebased and fixed commit message.

@IgorMinar
Copy link
Contributor

thanks for the rebase. the ci is now green

@IgorMinar IgorMinar removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 13, 2018
IgorMinar pushed a commit that referenced this pull request Apr 13, 2018
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close #23315
@IgorMinar IgorMinar closed this in 993eeab Apr 13, 2018
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close angular#23315
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close angular#23315
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
The service injected is `ValueService`, however the name of the variable
does not reflect that. It's actually confusing since it's the name of
the `class` being created.

PR Close angular#23315
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants