New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(demo): fix typo in injected variable name #23315
Conversation
caretaker note: can you update this pr with commit message: "docs: ..." rather than "docs(demo): ..." |
sure thing. Should I be worried about the ci failures ? They seem unrelated to my changes. |
The service injected is `ValueService`, however the name of the variable does not reflect that. It's actually confusing since it's the name of the `class` being created.
Rebased and fixed commit message. |
thanks for the rebase. the ci is now green |
The service injected is `ValueService`, however the name of the variable does not reflect that. It's actually confusing since it's the name of the `class` being created. PR Close #23315
The service injected is `ValueService`, however the name of the variable does not reflect that. It's actually confusing since it's the name of the `class` being created. PR Close angular#23315
The service injected is `ValueService`, however the name of the variable does not reflect that. It's actually confusing since it's the name of the `class` being created. PR Close angular#23315
The service injected is `ValueService`, however the name of the variable does not reflect that. It's actually confusing since it's the name of the `class` being created. PR Close angular#23315
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The service injected is
ValueService
, however the name of the variabledoes not reflect that. It's actually confusing since it's the name of
the
class
being created.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Simple typo in the docs of
angular.io
.Does this PR introduce a breaking change?
Other information