Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix aio size tracking, we need to use node_modules local to aio #23328

Closed
wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.
@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Apr 11, 2018
@mary-poppins
Copy link

You can preview 81f708f at https://pr23328-81f708f.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker cla: no and removed cla: yes labels Apr 12, 2018
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 12, 2018
@ngbot
Copy link

ngbot bot commented Apr 12, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Apr 12, 2018
IgorMinar added a commit that referenced this pull request Apr 12, 2018
#23328)

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.

PR Close #23328
@IgorMinar IgorMinar closed this in 7e8cee6 Apr 12, 2018
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
angular#23328)

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.

PR Close angular#23328
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
angular#23328)

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.

PR Close angular#23328
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 13, 2018
angular#23328)

This fixes an issue introduced by 4f0cae0 which removed firebase from the root node_modules.

PR Close angular#23328
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants