Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(common): mark locales files as side-effect-full #23366

Closed

Conversation

IgorMinar
Copy link
Contributor

These files are in the UMD format for greater portablity, and as such
can't be marked as side-effect-free by webpack/build-optimizer/uglify.

These files are in the UMD format for greater portablity, and as such
can't be marked as side-effect-free by webpack/build-optimizer/uglify.
@IgorMinar IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 13, 2018
@IgorMinar
Copy link
Contributor Author

I manually verified that the package.json makes it through

@mary-poppins
Copy link

You can preview b92ca62 at https://pr23366-b92ca62.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6183c12 at https://pr23366-6183c12.ngbuilds.io/.

@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label Apr 13, 2018
@@ -0,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "description": "Workaround for [issue] that makes BuildOptimizer not mark these UMD files as @PURE"

@alexeagle alexeagle removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 13, 2018
@mary-poppins
Copy link

You can preview 575a647 at https://pr23366-575a647.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Apr 13, 2018
@ngbot
Copy link

ngbot bot commented Apr 13, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants