New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(common): mark locales files as side-effect-full #23366
build(common): mark locales files as side-effect-full #23366
Conversation
These files are in the UMD format for greater portablity, and as such can't be marked as side-effect-free by webpack/build-optimizer/uglify.
I manually verified that the package.json makes it through |
You can preview b92ca62 at https://pr23366-b92ca62.ngbuilds.io/. |
You can preview 6183c12 at https://pr23366-6183c12.ngbuilds.io/. |
@@ -0,0 +1,3 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "description": "Workaround for [issue] that makes BuildOptimizer not mark these UMD files as @PURE"
You can preview 575a647 at https://pr23366-575a647.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
These files are in the UMD format for greater portablity, and as such
can't be marked as side-effect-free by webpack/build-optimizer/uglify.