New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ivy): cleanup directives & pipes import #23369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one nit.
if (directiveExps.length) { | ||
field('directives', o.literalArr(directiveExps)); | ||
|
||
if (directives.size) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here to match format of others? e.g. 'directives: [MyDir]'
You can preview 27f32c2 at https://pr23369-27f32c2.ngbuilds.io/. |
You can preview 84cf3b2 at https://pr23369-84cf3b2.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.