Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update CLDR data for closure locale & use a const for undefined #23372

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Apr 13, 2018

PR Type

What kind of change does this PR introduce?

[x] Refactoring (no functional changes, no api changes)

What is the current behavior?

We need to update the closure locale (that was missed in #23265)

What is the new behavior?

Closure locale updated

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release labels Apr 13, 2018
@ocombe ocombe requested a review from vicb April 13, 2018 21:43
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2018
@mary-poppins
Copy link

You can preview 82bba1b at https://pr23372-82bba1b.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Apr 13, 2018

@ocombe ocombe requested a review from alexeagle April 13, 2018 22:25
@IgorMinar IgorMinar closed this in d1177c7 Apr 13, 2018
@ocombe ocombe deleted the fix/closure-locales branch April 14, 2018 05:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants