Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): cleanup of the view compiler #23375

Closed
wants to merge 2 commits into from
Closed

refactor(ivy): cleanup of the view compiler #23375

wants to merge 2 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 13, 2018

No description provided.

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy labels Apr 13, 2018
@mary-poppins
Copy link

You can preview 4cd178e at https://pr23375-4cd178e.ngbuilds.io/.

@vicb
Copy link
Contributor Author

vicb commented Apr 13, 2018 •
edited

http://test/OCL:192838588:BASE:192839084:1523660959764:93d61576

@mary-poppins
Copy link

You can preview 2c9ad2d at https://pr23375-2c9ad2d.ngbuilds.io/.

@vicb vicb force-pushed the 0413-viewcomp branch 2 times, most recently from f0459fa to 299b50e Compare April 13, 2018 23:51
mhevery
mhevery approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but please fix the constant pool thing.

packages/compiler/test/render3/r3_compiler_compliance_spec.ts Outdated
@@ -610,7 +610,7 @@ describe('compiler compliance', () => {
factory: function ComplexComponent_Factory() { return new ComplexComponent(); },
template: function ComplexComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵpD(0, $c1$);
$r3$.ɵpD(0, $c1$, ['span[title=toFirst]', 'span[title=toSecond]']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constant pool.

@mary-poppins
Copy link

You can preview 299b50e at https://pr23375-299b50e.ngbuilds.io/.

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 14, 2018
@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2018

http://test/OCL:192838588:BASE:192845806:1523664248804:9f587742

@mary-poppins
Copy link

You can preview ab52004 at https://pr23375-ab52004.ngbuilds.io/.

@IgorMinar IgorMinar closed this in ac683d7 Apr 14, 2018
IgorMinar pushed a commit that referenced this pull request Apr 14, 2018
@vicb @IgorMinar
fix(ivy): add unparsed selectors to the projectionDef instruction (#…
80e483c 
…23375)

PR Close #23375
@vicb vicb deleted the 0413-viewcomp branch May 14, 2018 22:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @mary-poppins @mhevery @googlebot