refactor(compiler): refactor template binding parsing #23460
Conversation
A long time ago Angular used to support both those attribute notations: - `*attr='binding'` - `template=`attr: binding` Because the last notation has been dropped we can refactor the binding parsing. Source maps will benefit from that as no `attr:` prefix is added artificialy any more.
vicb
added
action: review
| bindings.push(new TemplateBinding(this.span(start), key, keyIsVar, name, expression)); | ||
| if (this.peekKeywordAs() && !keyIsVar) { | ||
|
|
||
| bindings.push(new TemplateBinding(this.span(start), key, isVar, name, expression)); |
There was a problem hiding this comment.
Is there value in pushing a binding with no expression? Or is that what happens when you do *dir="let foo"?
There was a problem hiding this comment.
that's exact. A var has a key and a name only (foo/$implicit)
|
You can preview 25bb278 at https://pr23460-25bb278.ngbuilds.io/. |
vicb
added
target: major
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
lint is failing because of an old commit message |
| @@ -736,8 +729,9 @@ export class _ParseAST { | |||
| if (!this.optionalCharacter(chars.$SEMICOLON)) { | |||
| this.optionalCharacter(chars.$COMMA); | |||
| } | |||
| } | |||
| return new TemplateBindingParseResult(bindings, warnings, this.errors); | |||
| } while (this.index < this.tokens.length) | |||
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
A long time ago Angular used to support both those attribute notations:
*attr='binding'template=attr: binding`Because the last notation has been dropped we can refactor the binding parsing.
Source maps will benefit from that as no
attr:prefix is added artificialy anymore.