Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change capitalization for css hex color values #23511

Closed
wants to merge 3 commits into from

Conversation

sreevani-ship-it
Copy link
Contributor

@sreevani-ship-it sreevani-ship-it commented Apr 23, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

inconsistent capitalization of css hex color values.
Issue Number: 23113 #23113

What is the new behavior?

changed hex color values from uppercase to lowercase and used 3 character hexadecimal notation where possible.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mary-poppins
Copy link

You can preview 159d7e6 at https://pr23511-159d7e6.ngbuilds.io/.

@jainanuj0812
Copy link
Contributor

jainanuj0812 commented Apr 24, 2018

As per the discussion over the issue thread, I don't think it is approved or required.

And if these changes requested to be pushed, it should be changed globally and not in these particular files.

@jenniferfell jenniferfell added the target: patch This PR is targeted for the next patch release label May 10, 2018
}
nav a:hover {
color: #039be5;
background-color: #CFD8DC;
background-color: #cfd;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some characters get dropped accidentally? CFD8DC seems to be a medium gray, and CFD seems to be a bright green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed hex code style recommendation and reduced it to 3 digits. But on a second look, the RGB values are different when it is 3 digits. Reverted it back to 6 digit code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-digit hex color values are equivalent to 6-digit color values with each digit duplicated. I.e. #cfd is the same as #ccffdd, which is indeed quit different than #cfd8dc (in 6-digit hex color values each digit pair corresponds to one of R, G, B).

@jenniferfell jenniferfell removed the request for review from IgorMinar May 18, 2018 00:19
@jenniferfell jenniferfell added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 22, 2018
@jenniferfell jenniferfell requested review from IgorMinar and gkalpak and removed request for gkalpak May 22, 2018 22:33
@jenniferfell
Copy link
Contributor

@IgorMinar On the associated issue, @jelbourn comments that the Google style is lowercase.

}
nav a:hover {
color: #039be5;
background-color: #CFD8DC;
background-color: #cfd8dc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after colon

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked if there are more, but the changes on this PR lgtm.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the extra ws issue and pushed to this PR. lgtm now.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker cla: yes and removed cla: no labels Jun 12, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@ngbot
Copy link

ngbot bot commented Jun 12, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure forbidden label detected: PR action: review
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants