New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change capitalization for css hex color values #23511
Conversation
You can preview 159d7e6 at https://pr23511-159d7e6.ngbuilds.io/. |
As per the discussion over the issue thread, I don't think it is approved or required. And if these changes requested to be pushed, it should be changed globally and not in these particular files. |
} | ||
nav a:hover { | ||
color: #039be5; | ||
background-color: #CFD8DC; | ||
background-color: #cfd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some characters get dropped accidentally? CFD8DC seems to be a medium gray, and CFD seems to be a bright green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed hex code style recommendation and reduced it to 3 digits. But on a second look, the RGB values are different when it is 3 digits. Reverted it back to 6 digit code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3-digit hex color values are equivalent to 6-digit color values with each digit duplicated. I.e. #cfd
is the same as #ccffdd
, which is indeed quit different than #cfd8dc
(in 6-digit hex color values each digit pair corresponds to one of R, G, B).
@IgorMinar On the associated issue, @jelbourn comments that the Google style is lowercase. |
} | ||
nav a:hover { | ||
color: #039be5; | ||
background-color: #CFD8DC; | ||
background-color: #cfd8dc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space after colon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked if there are more, but the changes on this PR lgtm.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the extra ws issue and pushed to this PR. lgtm now.
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
inconsistent capitalization of css hex color values.
Issue Number: 23113 #23113
What is the new behavior?
changed hex color values from uppercase to lowercase and used 3 character hexadecimal notation where possible.
Does this PR introduce a breaking change?
Other information