Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aio): fix print styles #23538

Closed
wants to merge 4 commits into from
Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Apr 25, 2018

Fix/improve the print styles of angular.io.
This supersedes #23500. Fixes #23431.

@gkalpak gkalpak added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: patch This PR is targeted for the next patch release and removed cla: yes labels Apr 25, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@mary-poppins
Copy link

You can preview 6e80c48 at https://pr23538-6e80c48.ngbuilds.io/.

Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better.
Is it possible to get headings to move onto the same page as the following table if the table does not fit on the current page. I think this is called "orphan headings"?
See the print preview for https://pr23538-6e80c48.ngbuilds.io/api/common/CurrencyPipe

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 4, 2018
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra May 4, 2018
@IgorMinar IgorMinar closed this in 14d8a98 May 4, 2018
@gkalpak gkalpak removed this from MERGE in docs-infra May 5, 2018
@gkalpak
Copy link
Member Author

gkalpak commented May 9, 2018

Is it possible to get headings to move onto the same page as the following table if the table does not fit on the current page.

We do use page-break-after: avoid for all headings, which is supposed to have that effect (but apparently doesn't). I also tried break-after: avoid-page (which is the new way to do it, but supported by fewer browsers) and still doesn't work ¯\_(ツ)_/¯

h1, h2, h3, h4, h5, h6 {
page-break-after: avoid;
}

@petebacondarwin
Copy link
Member

What about break-after: avoid?

@gkalpak
Copy link
Member Author

gkalpak commented May 9, 2018

Same. Doesn't work.

@gkalpak gkalpak deleted the fix-aio-print-styles branch July 11, 2018 14:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Code samples aren't visible when printed
4 participants