Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): updates doc error in guide/http #23567

Closed
wants to merge 1 commit into from
Closed

docs(aio): updates doc error in guide/http #23567

wants to merge 1 commit into from

Conversation

bennetthardwick
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

https://angular.io/guide/http#testing-for-errors

Currently the documentation says to call req.error when forcing a network failure, but instead gives an example using req.flush.

Issue Number: #23453

What is the new behavior?

The documentation now shows two correct examples. One using req.error, simulating a network failure, and one using req.flush, simulating a 404.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Updates documentation to include examples for both req.flush and
req.error in http testing examples.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@bennetthardwick bennetthardwick changed the title docs(aio): update docs error in guide/http docs(aio): updates doc error in guide/http Apr 27, 2018
@bennetthardwick
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 27, 2018
@ngbot
Copy link

ngbot bot commented Apr 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar closed this in cc6c434 Apr 27, 2018
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
Updates documentation to include examples for both req.flush and
req.error in http testing examples.

PR Close #23567
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
Updates documentation to include examples for both req.flush and
req.error in http testing examples.

PR Close #23567
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants