Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aio): add v6 release notification #23690

Closed
wants to merge 1 commit into from
Closed

feat(aio): add v6 release notification #23690

wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: patch This PR is targeted for the next patch release labels May 3, 2018
@mary-poppins
Copy link

You can preview 79fb4e8 at https://pr23690-79fb4e8.ngbuilds.io/.

petebacondarwin
petebacondarwin approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petebacondarwin
Copy link
Member

Although I am not sure why there is this error: https://travis-ci.org/angular/angular/jobs/374650210#L1452-L1463

Has this something to do with releasing v6? @gkalpak ?

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 4, 2018
@ngbot
Copy link

ngbot bot commented May 4, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar closed this in b25e15c May 4, 2018
IgorMinar added a commit that referenced this pull request May 4, 2018
@IgorMinar
feat(aio): add v6 release notification (#23690)
07f2098 
PR Close #23690
@IgorMinar
Copy link
Contributor Author

@petebacondarwin the error was due to my fix of the deployment script for archival branches (it was incorrect) - I missed updating the the test. it's all fixed now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IgorMinar @mary-poppins @petebacondarwin @googlebot