Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(elements): add angular element term to glossary #23807

Closed

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@jbogarthyde jbogarthyde added comp: docs target: patch This PR is targeted for the next patch release area: elements Issues related to Angular Elements labels May 9, 2018
@mary-poppins
Copy link

You can preview 69440b8 at https://pr23807-69440b8.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 10, 2018
@ngbot
Copy link

ngbot bot commented May 10, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@@ -28,6 +28,11 @@ By compiling your application using the `ngc` command-line tool, you can bootstr

Compare [just-in-time (JIT) compilation](guide/glossary#jit).

## Angular element
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we have previously capitalized E in Elements. Was that wrong? Or should we update this with capital E?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in person - it should be lower case e

@@ -28,6 +28,11 @@ By compiling your application using the `ngc` command-line tool, you can bootstr

Compare [just-in-time (JIT) compilation](guide/glossary#jit).

## Angular element
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in person - it should be lower case e

@IgorMinar IgorMinar closed this in c4221da May 10, 2018
@jbogarthyde jbogarthyde deleted the jb-glossary-angular-element branch May 24, 2018 17:34
mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: elements Issues related to Angular Elements cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants