Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): avoid creating bound function in pipeBind3 #23882

Closed
wants to merge 1 commit into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented May 13, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[x] Other... Please describe:
Performance improvement

What is the current behavior?

Unlike all other pipeBind# functions, pipeBind3 was creating a new bound function with each update, even when the pipe's input did not change.

What is the new behavior?

Reusing pureFunction3's ability to specify the calling context of the pureFn invocation, such that creating a bound function is not necessary.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels May 14, 2018
@marclaval
Copy link
Contributor

LGTM, good catch

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes labels May 14, 2018
@ngbot
Copy link

ngbot bot commented May 14, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "cla: yes"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb
Copy link
Contributor

vicb commented May 14, 2018

@alxhub alxhub closed this in 83631b2 May 15, 2018
mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018
@JoostK JoostK deleted the ivy-pipe-refactoring branch June 2, 2018 09:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants