Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test change for core_package #24076

Closed
jasonaden opened this issue May 23, 2018 · 3 comments
Closed

Revert test change for core_package #24076

jasonaden opened this issue May 23, 2018 · 3 comments
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq4: critical regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Milestone

Comments

@jasonaden
Copy link
Contributor

Part of landing Ivy platform bootstrap required adjusting a Bazel test for license info. From #23811 in https://github.com/angular/angular/blob/master/packages/bazel/test/ng_package/core_package.spec.ts#L108

@jasonaden jasonaden added type: bug/fix freq4: critical regression Indicates than the issue relates to something that worked in a previous version area: bazel Issues related to the published `@angular/bazel` build rules labels May 23, 2018
@ngbot ngbot bot added this to the Backlog milestone May 23, 2018
@alexeagle
Copy link
Contributor

I don't understand - do you still have an issue? I don't see a change to that test which should be reverted.

@alexeagle
Copy link
Contributor

Jason said on chat that it's obsolete

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq4: critical regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Projects
None yet
Development

No branches or pull requests

2 participants