Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding property/event bindings to ng-content should error #24259

Open
jelbourn opened this issue Jun 1, 2018 · 1 comment
Open

Adding property/event bindings to ng-content should error #24259

jelbourn opened this issue Jun 1, 2018 · 1 comment
Labels
area: core Issues related to the framework runtime core: content projection design complexity: low-hanging freq1: low hotlist: error messages state: confirmed type: bug/fix
Milestone
Ivy (not in use)

Comments

@jelbourn
Copy link
Member

jelbourn commented Jun 1, 2018 •
edited by vicb

Issue

Adding property/event bindings to <ng-content> (attributes that are not explicitly supported APIs) currently no-op. They should be an error, as the attributes will be completely lost.

Reproduction

https://stackblitz.com/edit/angular-gitter-hm6egs?file=app%2Fapp.component.ts
@jelbourn jelbourn mentioned this issue Jun 1, 2018
Closed
@vicb vicb changed the title Adding unsupported attributes to ng-content should error Adding property/event bindings to ng-content should error Jun 1, 2018
@vicb
Copy link
Contributor

vicb commented Jun 1, 2018

Adding an attribute could be used for re-projection: <ng-content selector="a[title]" someRandomName></ng-content> and then <ng-content selector="[someRandomName]"></ng-content>

@vicb vicb added type: bug/fix freq1: low severity1: confusing area: core Issues related to the framework runtime labels Jun 1, 2018
@ngbot ngbot bot added this to the Backlog milestone Jun 1, 2018
@vicb vicb modified the milestones: Backlog, Ivy Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime core: content projection design complexity: low-hanging freq1: low hotlist: error messages state: confirmed type: bug/fix
Projects
None yet
Milestone
Ivy (not in use)
Development

No branches or pull requests
4 participants
@vicb @jelbourn @pkozlowski-opensource @AndrewKushnir