Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update rxjs link to version 6 #24269

Closed
wants to merge 1 commit into from
Closed

docs: update rxjs link to version 6 #24269

wants to merge 1 commit into from

Conversation

EbonyAdder
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

A link on "RxJS Library" was pointing a page that referenced RxJS 5 operators.
Issue Number: N/A

What is the new behavior?

The link, and some surrounding text, has been updated to point to RxJS 6 documentation.

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@brandonroberts brandonroberts self-assigned this Jul 4, 2018
@brandonroberts brandonroberts added comp: docs target: patch This PR is targeted for the next patch release labels Jul 4, 2018
@@ -45,7 +45,7 @@ The `pipe()` function is also a method on the RxJS `Observable`, so you use this

### Common operators

RxJS provides many operators (over 150 of them), but only a handful are used frequently. Here is a list of common operators; for usage examples, see [RxJS 5 Operators By Example](https://github.com/btroncone/learn-rxjs/blob/master/operators/complete.md) in RxJS documentation.
RxJS provides many operators, but only a handful are used frequently. For a list of operators and usage samples, please view the [RxJS API Documentation](https://rxjs-dev.firebaseapp.com/api).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change wording to visit instead of please view.

@brandonroberts brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 5, 2018
@brandonroberts brandonroberts changed the title docs(aio): update rxjs link to version 6 docs: update rxjs link to version 6 Jul 20, 2018
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 23, 2018
vicb pushed a commit that referenced this pull request Jul 23, 2018
@vicb vicb closed this in 4263245 Jul 23, 2018
@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Oct 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants