Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Angular CLI Command #24437

Closed
wants to merge 1 commit into from

Conversation

RicardoVaranda
Copy link
Contributor

@RicardoVaranda RicardoVaranda commented Jun 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If you try to run it with:
ng build --prod --sourcemaps

You get the following error message:
Unknown option: '--sourcemaps'

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@brandonroberts brandonroberts self-assigned this Jun 18, 2018
@brandonroberts
Copy link
Contributor

LGTM. Update your git commit message to follow the guidelines: "docs: update Angular CLI option for sourcemaps"

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release labels Jun 25, 2018
@ngbot
Copy link

ngbot bot commented Jun 25, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 25, 2018
@RicardoVaranda
Copy link
Contributor Author

Hi @brandonroberts , I've committed the required changes but it seems travis is still failing due to timeout, would you mind having a look?

@brandonroberts
Copy link
Contributor

brandonroberts commented Jun 25, 2018

Sure @RicardoVaranda. The caretaker will get it merged if Travis keeps being flakey. I'll run it again to see if it passes

@mhevery mhevery closed this in fe8fe9b Jun 25, 2018
mhevery pushed a commit that referenced this pull request Jun 25, 2018
@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Oct 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants