ngInjectorDef generation in JIT and AOT #24632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 9c7d657 at https://pr24632-9c7d657.ngbuilds.io/. |
|
You can preview 73c82cd at https://pr24632-73c82cd.ngbuilds.io/. |
benlesh
approved these changes
Jun 22, 2018
|
You can preview db3f5da at https://pr24632-db3f5da.ngbuilds.io/. |
|
You can preview 92d60f7 at https://pr24632-92d60f7.ngbuilds.io/. |
|
You can preview 1bde04f at https://pr24632-1bde04f.ngbuilds.io/. |
This change generates ngInjectorDef as well as ngModuleDef for @NgModule annotated types, reflecting the dual nature of @ngModules as both compilation scopes and as DI configuration containers. This required implementing ngInjectorDef compilation in @angular/compiler as well as allowing for multiple generated definitions for a single decorator in the core of ngtsc.
This commit takes advantage of the @angular/compiler work for ngInjectorDef in AOT mode in order to generate the same definition in JIT mode.
|
You can preview 4eaa484 at https://pr24632-4eaa484.ngbuilds.io/. |
mhevery
approved these changes
Jun 25, 2018
alxhub
added
action: merge
jasonaden
pushed a commit
that referenced
this pull request
Jun 26, 2018
This commit takes advantage of the @angular/compiler work for ngInjectorDef in AOT mode in order to generate the same definition in JIT mode. PR Close #24632
jasonaden
pushed a commit
that referenced
this pull request
Jun 26, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.