Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): run render3 tests with test.sh #24866

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Jul 13, 2018

PR Type

What kind of change does this PR introduce?

[x] Test related changes

What is the current behavior?

Render3 tests have been excluded from karma (test.sh) because there's a test that only works with bazel

What is the new behavior?

I changed the exclusion to only exclude the bazel-only tests, so that people on windows (me) can still run render3 tests with karma until bazel works on Windows

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added area: testing Issues related to Angular testing features, such as TestBed target: major This PR is targeted for the next major release comp: ivy labels Jul 13, 2018
@ocombe ocombe requested a review from alxhub July 13, 2018 08:57
@ocombe ocombe added the action: merge The PR is ready for merge by the caretaker label Jul 13, 2018
@matsko matsko closed this in 1821b75 Jul 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants