Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove Tina from pullaprove #25006

Closed
wants to merge 1 commit into from
Closed

ci: remove Tina from pullaprove #25006

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jul 20, 2018

No description provided.

@vicb
ci: remove Tina from pullaprove
5fffba3 
She has been removed as a collaborator to the project and pullaprove rejects
this config file which still lists her name.
@vicb vicb added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 20, 2018
@ngbot
Copy link

ngbot bot commented Jul 20, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "code-review/pullapprove" is failing
    failure missing required status "continuous-integration/travis-ci/pr"
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_ivy_jit" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: lint" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb closed this in 2aab1c9 Jul 20, 2018
vicb added a commit that referenced this pull request Jul 20, 2018
@vicb
ci: remove Tina from pullaprove (#25006)
28de0c7 
She has been removed as a collaborator to the project and pullaprove rejects
this config file which still lists her name.

PR Close #25006
@vicb vicb deleted the 0720-pullapprove branch August 3, 2018 19:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vicb @alxhub @googlebot