Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor ngmodules example #25072

Closed
wants to merge 1 commit into from

Conversation

danielsogl
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Unused modules are imported

What is the new behavior?

Removed unused module imports

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@danielsogl
Copy link
Contributor Author

cc @brandonroberts

@mary-poppins
Copy link

You can preview e065e97 at https://pr25072-e065e97.ngbuilds.io/.

@brandonroberts brandonroberts added comp: docs target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 25, 2018
@brandonroberts brandonroberts self-assigned this Jul 25, 2018
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jul 25, 2018
@vicb vicb closed this in c205516 Jul 25, 2018
vicb pushed a commit that referenced this pull request Jul 25, 2018
@danielsogl danielsogl deleted the aio_ngmodules_refactor branch July 25, 2018 05:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants